Remove unused chectl flag by dkwon17 · Pull Request #1474 · devfile/devworkspace-operator

dkwon17 · 2025-07-29T18:37:40Z

What does this PR do?

Removes the --workspace-engine=dev-workspace flag in the ci job

What issues does this PR fix or reference?

Should fix this error in the ci check:

+ chectl server:deploy -p openshift --batch --telemetry=off --installer=operator --workspace-engine=dev-workspace
Error: Nonexistent flag: --workspace-engine=dev-workspace
See more help with --help
    at validateArgs (/usr/local/lib/chectl/node_modules/@oclif/core/lib/parser/validate.js:10:19)
    at validate (/usr/local/lib/chectl/node_modules/@oclif/core/lib/parser/validate.js:173:5)
    at Object.parse (/usr/local/lib/chectl/node_modules/@oclif/core/lib/parser/index.js:19:35)
    at async Deploy.parse (/usr/local/lib/chectl/node_modules/@oclif/core/lib/command.js:246:25)>

Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/devfile_devworkspace-operator/1461/pull-ci-devfile-devworkspace-operator-main-v14-che-happy-path/1949933534399434752

Is it tested? How?

PR Checklist

E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
- v8-devworkspace-operator-e2e: DevWorkspace e2e test
- v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: David Kwon <dakwon@redhat.com>

openshift-ci · 2025-07-29T18:37:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: David Kwon <dakwon@redhat.com>

rohanKanojia · 2025-07-30T05:22:54Z

/retest

rohanKanojia · 2025-07-30T10:19:29Z

It's quite strange, even after defining a long timeout it's failing

[06:23:49] → ERR_TIMEOUT: Timeout set to pod ready timeout 240000
[06:23:49] Install Dev Workspace operator [failed]
[06:23:49] → ERR_TIMEOUT: Timeout set to pod ready timeout 240000
[06:23:49] Deploy Eclipse Che [failed]
[06:23:49] → ERR_TIMEOUT: Timeout set to pod ready timeout 240000
Error: Command server:deploy failed with the error: ERR_TIMEOUT: Timeout set to pod ready timeout 240000 See details: /alabama/.cache/chectl/error.log. Eclipse Che logs: /tmp/chectl-logs/1753856327424.
    at newError (/usr/local/lib/chectl/lib/utils/utls.js:39:19)
    at wrapCommandError (/usr/local/lib/chectl/lib/utils/command-utils.js:54:32)
    at Deploy.<anonymous> (/usr/local/lib/chectl/lib/commands/server/deploy.js:82:65)
    at Generator.throw (<anonymous>)
    at rejected (/usr/local/lib/chectl/node_modules/tslib/tslib.js:167:69)
Cause: Error: ERR_TIMEOUT: Timeout set to pod ready timeout [240](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/devfile_devworkspace-operator/1474/pull-ci-devfile-devworkspace-operator-main-v14-che-happy-path/1950426868318474240#1:build-log.txt%3A240)000
    at KubeClient.<anonymous> (/usr/local/lib/chectl/lib/api/kube-client.js:828:19)
    at Generator.next (<anonymous>)
    at fulfilled (/usr/local/lib/chectl/node_modules/tslib/tslib.js:166:62)

rohanKanojia · 2025-07-30T12:43:50Z

    --telemetry=off \
-    --installer=operator \
-    --workspace-engine=dev-workspace
+    --k8spodreadytimeout=240000 \


I see that in che-operator we're using slightly longer timeout --k8spodreadytimeout=6000000

https://github.com/eclipse-che/che-operator/blob/d4a50d89668f6c08f56d9db627f996fd733971a5/build/scripts/minikube-tests/test-operator.sh#L36

I see, I will update the PR

Signed-off-by: David Kwon <dakwon@redhat.com>

dkwon17 · 2025-07-31T22:27:20Z

I realized it's timing out because chectl is waiting for the DWO operands to be ready in the openshift-operators namespace, when the operands are already running in the devworkspace-controller namespace.

The DWO operands in openshift-operators never get into the running state because of:

2025-07-30T22:33:27.986739680Z {"level":"error","ts":"2025-07-30T22:33:27Z","logger":"setup","msg":"failed to setup webhooks","error":"conflicting webhook definition found on cluster, webhook mutate.devworkspace-controller.svc clientConfig points at namespace devworkspace-controller","stacktrace":"main.main\n\t/devworkspace-operator/main.go:202\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:272"}

since the operands in devworkspace-controller are running first.

My commit: b6c668e should fix the problem

Signed-off-by: David Kwon <dakwon@redhat.com>

dkwon17 · 2025-08-01T02:44:54Z

There is a new error:

Launching DevWorkspace Happy path from /tmp/che-devworkspace-happy-path
[INFO] Testing if Che User exists.
Login failed (401 Unauthorized)
Verify you have provided the correct credentials.
[INFO] Che User does not exist. Setting up htpasswd oauth for it.
Error from server (NotFound): secrets "dev-htpasswd-secret" not found
secret/dev-htpasswd-secret created
/tmp/che-devworkspace-happy-path/che-main/tests/devworkspace-happy-path/provision-openshift-oauth-user.sh: line 44: jq: command not found
/tmp/che-devworkspace-happy-path/che-main/tests/devworkspace-happy-path/provision-openshift-oauth-user.sh: line 48: jq: command not found

rohanKanojia · 2025-08-01T06:16:44Z

/retest

Signed-off-by: David Kwon <dakwon@redhat.com>

dkwon17 · 2025-08-01T22:24:20Z

/retest

dkwon17 · 2025-08-02T01:32:04Z

/retest

rohanKanojia · 2025-08-04T08:03:13Z

With these changes, I can see that chectl is correctly installing che instance onto CI. However, che-happy-path test is failing, in logs I see this error:

ls: cannot access 'specs/devfiles': No such file or directory

Do you have any idea about this?

dkwon17 · 2025-08-05T21:52:11Z

I think I figured out the issue, specs/devfile does not exist and was moved to specs/dashboard-samples:
eclipse-che/che@6e179e6#diff-d09ed96d02e67f5e9756aec75f875cfa33ec6b906b76ee3b0abae86854c55152

I will create a new issue

dkwon17 · 2025-08-06T18:00:23Z

/retest

dkwon17 · 2025-08-06T20:11:44Z

Merging, happy path tests now passed!

Remove unused chectl flag

76d3cd5

Signed-off-by: David Kwon <dakwon@redhat.com>

dkwon17 requested review from akurinnoy, ibuziuk and rohanKanojia as code owners July 29, 2025 18:37

openshift-ci Bot added the approved label Jul 29, 2025

dkwon17 mentioned this pull request Jul 29, 2025

fix : execute preStart devfile events after project-clone initContainer #1461

Merged

3 tasks

dkwon17 added 2 commits July 29, 2025 17:32

Increase podreadytimeout

5f1880b

Signed-off-by: David Kwon <dakwon@redhat.com>

Increase podreadytimeout

f38176c

Signed-off-by: David Kwon <dakwon@redhat.com>

rohanKanojia reviewed Jul 30, 2025

View reviewed changes

dkwon17 added 2 commits July 30, 2025 15:08

Set podwaittimeout and podreadytimeout

a2b5c4e

Signed-off-by: David Kwon <dakwon@redhat.com>

Add --skip-devworkspace-operator since DWO is already installed

b6c668e

Signed-off-by: David Kwon <dakwon@redhat.com>

Remove unused flag

0196cd9

Signed-off-by: David Kwon <dakwon@redhat.com>

Add jq in the e2e tests image

1bfa77c

Signed-off-by: David Kwon <dakwon@redhat.com>

dkwon17 mentioned this pull request Aug 1, 2025

Add jq in the e2e tests image #1479

Merged

3 tasks

rohanKanojia mentioned this pull request Aug 6, 2025

fix (tests) : update userstory path to specs/dashboard-samples (#23514) eclipse-che/che#23515

Merged

9 tasks

dkwon17 merged commit f5dc5f8 into devfile:main Aug 6, 2025
11 checks passed

Conversation

dkwon17 commented Jul 29, 2025

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

Uh oh!

openshift-ci Bot commented Jul 29, 2025

Uh oh!

rohanKanojia commented Jul 30, 2025

Uh oh!

rohanKanojia commented Jul 30, 2025

Uh oh!

rohanKanojia Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

dkwon17 Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

dkwon17 commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwon17 commented Aug 1, 2025

Uh oh!

rohanKanojia commented Aug 1, 2025

Uh oh!

dkwon17 commented Aug 1, 2025

Uh oh!

dkwon17 commented Aug 2, 2025

Uh oh!

rohanKanojia commented Aug 4, 2025

Uh oh!

dkwon17 commented Aug 5, 2025

Uh oh!

dkwon17 commented Aug 6, 2025

Uh oh!

Uh oh!

dkwon17 commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkwon17 commented Jul 31, 2025 •

edited

Loading